Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: gRPC server for TxStatus endpoint (backport #3754) #3755

Merged
merged 2 commits into from
Aug 5, 2024
Merged

feat: gRPC server for TxStatus endpoint (backport #3754) #3755

merged 2 commits into from
Aug 5, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 3, 2024

Closes: #3753

This in some ways ties into #3421

This is an automatic backport of pull request #3754 done by Mergify.

@cmwaters @mergify
feat: gRPC server for TxStatus endpoint (#3754)
ee9412f 
Closes: #3753

This in some ways ties into
#3421

(cherry picked from commit bb4f712)

# Conflicts:
#	app/app.go
#	app/test/std_sdk_test.go
#	app/test/testnode_test.go
@mergify Mergify
Copy link
Contributor Author

mergify bot commented Aug 3, 2024

Cherry-pick of bb4f712 has failed:

On branch mergify/bp/v1.x/pr-3754
Your branch is up to date with 'origin/v1.x'.

You are currently cherry-picking commit bb4f7128.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   app/grpc/tx/server.go
	new file:   app/grpc/tx/tx.pb.go
	new file:   app/grpc/tx/tx.pb.gw.go
	modified:   buf.yaml
	new file:   proto/celestia/core/v1/tx/tx.proto
	new file:   test/util/testnode/testnode_test.go

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	both modified:   app/app.go
	both modified:   app/test/std_sdk_test.go
	deleted by them: app/test/testnode_test.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot added the conflicts label Aug 3, 2024
@mergify mergify bot requested a review from a team as a code owner August 3, 2024 08:44
@mergify mergify bot requested review from rootulp and rach-id August 3, 2024 08:44
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 3, 2024 •
edited
Loading

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the bot item was created by a bot label Aug 3, 2024
@rootulp rootulp marked this pull request as draft August 3, 2024 22:46
@cmwaters cmwaters removed the conflicts label Aug 5, 2024
@cmwaters cmwaters self-assigned this Aug 5, 2024
@cmwaters cmwaters marked this pull request as ready for review August 5, 2024 09:15
@cmwaters cmwaters merged commit 548e21a into v1.x Aug 5, 2024
25 checks passed
@cmwaters cmwaters deleted the mergify/bp/v1.x/pr-3754 branch August 5, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmwaters cmwaters cmwaters approved these changes

@rootulp rootulp rootulp approved these changes

@rach-id rach-id Awaiting requested review from rach-id rach-id is a code owner automatically assigned from celestiaorg/celestia-core

Assignees

@cmwaters cmwaters

Labels
bot item was created by a bot
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rootulp @cmwaters